Inertia and Damper are also condition-ed effects.#169
Merged
emberian merged 2 commits intoemberian:mainfrom Mar 13, 2026
Merged
Inertia and Damper are also condition-ed effects.#169emberian merged 2 commits intoemberian:mainfrom
emberian merged 2 commits intoemberian:mainfrom
Conversation
The four condition-ed effects are spring, friction, damper, inertia: Ref: Universal Serial Bus (USB) Device Class Definition for Physical Interface Devices (PID) https://www.usb.org/sites/default/files/documents/pid1_01.pdf page 11, Table 3: Effect Types
…s it masks erroneous cases such as forgotten to be handled properly effects.
|
Looks good to me. I need this as well for https://github.com/laanwj/remote-uinput-rs . |
laanwj
approved these changes
Feb 6, 2026
Contributor
Author
|
Dear maintainers, @emberian , @coolreader18 , please consider the patch as it fixes the 'bug' and shall "unblock" some projects (e.g. mentioned by @laanwj or mine) that need this to be handled properly. Please tell if any changes required. I've tested the patch locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The four condition-ed effects are spring, friction, damper, inertia: Ref: Universal Serial Bus (USB) Device Class Definition for Physical Interface Devices (PID) https://www.usb.org/sites/default/files/documents/pid1_01.pdf page 11, Table 3: Effect Types
Hi. Currently condition data is not propagated for inertia and damper effects, however it needs to.
The four condition-ed effects are spring, friction, damper, inertia:
Some refs:
Universal Serial Bus (USB) Device Class Definition for Physical Interface Devices (PID)
https://www.usb.org/sites/default/files/documents/pid1_01.pdf
page 11, Table 3: Effect Types
gdk ref
ffbtools also provide condition settings for those effects.
This patch adds condition data propagation to evdev API for the latter two effects.