Skip to content

[FEATURE ember-glimmer-angle-bracket-built-ins]#17735

Merged
rwjblue merged 5 commits into
masterfrom
angle-built-ins
Mar 18, 2019
Merged

[FEATURE ember-glimmer-angle-bracket-built-ins]#17735
rwjblue merged 5 commits into
masterfrom
angle-built-ins

Conversation

@chancancode

@chancancode chancancode commented Mar 14, 2019

Copy link
Copy Markdown
Member

Implementation of emberjs/rfcs#459

  • Remove {{dash-rule}}
  • Implement <Textarea />
    • <TextArea /> => "Did you mean <Textarea />?"
  • Implement <Input />
  • Implement <LinkTo />
  • Update documentation
    • How do we flag it?
    • "helper" -> "component"
      • What is the "namespace" for this?
    • How to show both invocation styles?

Comment thread packages/@ember/-internals/glimmer/lib/resolver.ts Outdated
@wycats
wycats force-pushed the angle-built-ins branch 6 times, most recently from 9f46a9f to 3585ee1 Compare March 16, 2019 01:01
Remove `{{dash-rule}}` for curly invocations.
Implement `<TextArea />` typo guard.
@wycats
wycats force-pushed the angle-built-ins branch 2 times, most recently from 27ac173 to 698f7e9 Compare March 16, 2019 23:55
@rwjblue rwjblue changed the title [WIP] [FEATURE ember-glimmer-angle-bracket-built-ins] [FEATURE ember-glimmer-angle-bracket-built-ins] Mar 18, 2019
@rwjblue

rwjblue commented Mar 18, 2019

Copy link
Copy Markdown
Member

Resolved conflicts, and removed WIP from title.

@chancancode will work on <LinkTo in a separate PR...

@rwjblue
rwjblue merged commit c8987af into master Mar 18, 2019
@rwjblue
rwjblue deleted the angle-built-ins branch March 18, 2019 19:36
rwjblue pushed a commit to rwjblue/ember-octane-blueprint that referenced this pull request Mar 18, 2019
NullVoxPopuli pushed a commit to ember-cli/ember-octane-blueprint that referenced this pull request Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants