fix(admin): show nav items in mobile sidebar drawer#490
Open
all3f0r1 wants to merge 1 commit intoemdash-cms:mainfrom
Open
fix(admin): show nav items in mobile sidebar drawer#490all3f0r1 wants to merge 1 commit intoemdash-cms:mainfrom
all3f0r1 wants to merge 1 commit intoemdash-cms:mainfrom
Conversation
Kumo's mobile sidebar renders inside a Sheet without a data-state attribute, so the GroupContent grid-rows selector (group-data-[state=expanded]) never matches and all section items stay at grid-rows-[0fr] (hidden). Adds a CSS override targeting [data-mobile="true"] to force group content open in the mobile drawer. Closes emdash-cms#454 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 0863a33 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/blocks
@emdash-cms/cloudflare
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the mobile sidebar not displaying navigation pages within sections (Content, Manage, Admin, Plugins). The section headers were visible but all pages inside them were hidden.
Root cause: Kumo's
Sidebarcomponent renders the mobile sidebar inside a Sheet/Dialog. The innerdiv[data-sidebar="sidebar"]getsdata-mobile="true"but nodata-stateattribute. Kumo'sSidebarGroupContentusesgrid-rows-[0fr]as default (hidden) and only shows content viagroup-data-[state=expanded]/sidebar:grid-rows-[1fr]. Withoutdata-state="expanded"on mobile, the selector never matches and all collapsible group content stays invisible.Fix: Adds a CSS override targeting
.emdash-sidebar[data-mobile="true"] [data-sidebar="group-content"]to forcegrid-template-rows: 1frin the mobile drawer.Closes #454
Type of change
Checklist
pnpm typecheckpassespnpm --silent lint:json | jq '.diagnostics | length'returns 0pnpm testpasses (or targeted tests for my change)pnpm formathas been runAI-generated code disclosure
Screenshots / test output
This is a CSS-only fix targeting the mobile sidebar drawer. The change is a single
grid-template-rows: 1fr !importantoverride scoped to[data-mobile="true"], matching the existing pattern used for collapsed sidebar icon mode.