fix: update Dockerfile to use production.txt for deployment#30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Changes the Dockerfile to install dependencies from
requirements/production.txtinstead ofrequirements/development.txt.Why
The deployment was failing because
gunicornis required to run the container in production. The container was being built withdevelopment.txt, so gunicorn was missing and the deploy broke on startup.Since
production.txtinherits frombase.txt, the container still gets all base dependencies, plus gunicorn, without the dev-only test tools.How to verify
development.txtin the workflow)app starts without the previous startup error