fix: gunicorn start command for production server port#32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces the Dockerfile start command with gunicorn (shell form) and
removes the dev
runservercommand.Why
The production deploy was returning 502. The deploy logs showed:
Error: '$PORT' is not a valid port number.Two problems were behind it:
runserver(dev server),not gunicorn.
$PORTunexpanded — the literal string
$PORTwas reaching gunicorn insteadof the port number Railway injects at runtime.
Using the shell form of
CMDlets the shell expand$PORTto the realport, so gunicorn binds correctly.
How to verify
$PORTerror and gunicorn startsreleasestep in the Procfile