Update builder configuration in railway.json#33
Merged
Conversation
Changed builder type to DOCKERFILE and specified dockerfilePath.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
startCommandfromrailway.json, letting the Dockerfile'sCMDdefine how the app starts.Why
The production deploy kept failing with:
Error: '$PORT' is not a valid port number.The start command was defined in three places (railway.json
startCommand,Dockerfile
CMD, and the Procfile), andrailway.jsontakes priority overthe others. Its
startCommandpassed$PORTin a form that wasn't expandedby a shell, so gunicorn received the literal string
$PORTinstead of theport Railway injects.
The Dockerfile
CMDalready uses the shell form, which expands$PORTcorrectly. Removing the
startCommandmakes the DockerfileCMDthe singlesource of truth for the start command and resolves the port error.
Notes
builderis kept asDOCKERFILEso the build still uses our Dockerfile(which installs gunicorn from production.txt)
How to verify
$PORTerror and gunicorn starts