fix(ci): stop opening duplicate schema update PRs - #137
Merged
Conversation
The existing-PR check passed a branch prefix to the head filter of pulls.list, which only matches an exact branch name, so it always reported no open PR. Paginate all open PRs and filter by prefix instead.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem. The nightly schema check has opened a new "chore: update types" PR every day (#133 to #136) even though one was already open. The guard step that checks for an existing PR passes a branch prefix to the `head` filter of the pull request list API. That filter only matches an exact branch name, so it never matched a dated branch and the step always reported no open PR. The run log for the September 8 scheduled run shows "No existing schema update PR found" while three such PRs were open.
Solution. The guard now pages through all open pull requests and filters client-side on branches starting with `chore/schema-update-`. It no longer depends on the `head` filter at all.
What to look at.
Test Plan.