Unify turns and events into ConversationView.items#144
Draft
benbaarber wants to merge 1 commit into
Draft
Conversation
Extracted from #108 as its structural prerequisite — the items IR without any compaction content. - ConversationView.turns/.events (two parallel vecs) become one ordered items: Vec<Item> (Turn | Event), preserving the source stream's exact interleaving. turns()/events() stay as iterators. - derive_path emits conversation.event steps for events (previously dropped — a Claude session lost its attachments and system entries on import/export), resolves duplicate step ids by content-aware renaming instead of erroring, and splices events onto the head's ancestry so they don't dangle as false dead ends. extract_conversation restores items, spliced parents, session files_changed, and synthetic-model actors. - Every provider's to_view now builds the ordered item stream. Native compaction markers stay opaque (a generic event, or pi's System turn) — typed boundaries are the follow-up's concern. - The claude projector emits events inline at their item position; real Claude interleaves attachments and system entries with turns, and the trailing-pass writer regrouped them at the end of the file. wire_order_roundtrip pins the projected entry-type sequence to the captured fixture's, and the caveat entry keeps isMeta. - Property tests: unique derived step ids, derive → extract → derive stability, and byte-identical replay dropping, over randomized turn/event interleavings with id collisions, dangling parents, and file mutations.
ben-emp
pushed a commit
that referenced
this pull request
Jul 23, 2026
…1.2.0) Restacked onto ben/items-ir (#144) with the standalone fixes split to #143; the pre-restack 43-commit history is preserved at ben/compaction-pre-split. The Compaction item + the conversation.compact step type (kind v1.2.0): a context-compaction boundary recorded as its own step between the turns it separates, with trigger, summary, pre_tokens, and the anchor-based kept contract (kept_from + expand_kept; the wire carries the expanded contiguous run). Compaction provenance is a closed typed set — no catch-all extra; native detail richer than the typed fields is deliberate loss. Per-provider support, each verified against the real harness TUI by resuming projected sessions (versions in docs/agents/tui-drift-check.md): - claude: compact_boundary + synthetic summary → typed boundary and back, preservedMessages as the kept run, transcript-only + isMeta render flags, empty-turn thinking-block projection. - codex: compacted marker → wholesale boundary (2026-07 payload: encrypted summary + prefix-keep documented as deliberate loss); projector emits the event_msg/context_compacted marker the TUI renders, with native turn_context placement. - opencode: per-boundary summary pairing, compaction-host parent redirects, tailStartID → kept anchor. - pi: compaction entries with parent-chain kept expansion; model_change/thinking_level_change/label as typed events with the chain's model context threaded into projected assistant messages. - copilot: the observed 1.0.68 session.compaction_start/complete pair mapped both directions (wholesale + summary). - gemini/cursor: documented no-boundary. Verification: executable round-trip oracle (testing::{check_view_invariants, assert_fixpoint}), compaction proptests, real captured compacted sessions for claude/codex/pi/ copilot/opencode as fixtures with looped stability tests, the cross-harness compaction matrix (kept-anchor capability flags), the env-gated real-session matrix mode, and import-time event-type surfacing.
|
🔍 Preview deployed: https://4976c5f9.toolpath.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #108 as its structural prerequisite — the items IR without any compaction content. #108 will restack on this branch.
ConversationView.turns/.events(two parallel vecs) become one ordereditems: Vec<Item>(Turn | Event), preserving the source stream's exact interleaving;turns()/events()remain as iterators.derive_pathemitsconversation.eventsteps for events (previously dropped — a Claude session lost its attachments and system entries on import/export), resolves duplicate step ids by content-aware renaming instead of erroring, and splices events onto the head's ancestry so they don't dangle as false dead ends.extract_conversationrestores items, spliced parents, sessionfiles_changed, and synthetic-model actors.to_viewbuilds the ordered item stream. Native compaction markers stay opaque here (a generic event, or pi's System turn) — typed boundaries are the follow-up's concern.wire_order_roundtrippins the projected entry-type sequence to the captured fixture's, and the caveat entry keepsisMeta.All 7 quality gates pass. Verified across every provider crate's full test suite.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.