Remove performance.now hackery which only exists for node v18 + DETERMINISTIC. NFC#26644
Closed
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Closed
Remove performance.now hackery which only exists for node v18 + DETERMINISTIC. NFC#26644sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
performance.now hackery which only exists for node v18 + DETERMINISTIC. NFC#26644sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
sbc100
changed the title
performance.now hackery which only exists for node v18 + `DE…performance.now hackery which only exists for node v18 + DETERMINISTIC. NFC
…TERMINISTIC`. NFC I don't think its worth the extra complexity to support `DETERMINISTIC` on node v18 since that combination is likely extremely rare. (I don't know of any active users of `-sDETERMINISTIC` myself).
Collaborator
Author
|
Closing in favor of #26648 (currently a draft) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think its worth the extra complexity to support
DETERMINISTICon node v18 since that combination is likely extremely rare.(I don't know of any active users of
-sDETERMINISTICmyself).