Suppress JDK 24 warnings when running java version of closure compiler#26661
Draft
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Draft
Suppress JDK 24 warnings when running java version of closure compiler#26661sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
Collaborator
Author
|
This issue seems to have gone away now.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the failure on the
test-mac-arm64bot. The reason the failure only occurs on that bot is that currently the version of closure compiler we are using from npm does not support macOS arm64 native so it falls back to Java, and I suppose the version of Java installed on the bots recently updated to one the reports warnings for things the closure compiler does. Those warnings then get interpreted by us as warnings from closure compiler itself, causing tests to fail.