Emsymbolizer: Remove VMA adjustment from llvm-symbolizer call#26665
Open
dschuff wants to merge 1 commit intoemscripten-core:mainfrom
Open
Emsymbolizer: Remove VMA adjustment from llvm-symbolizer call#26665dschuff wants to merge 1 commit intoemscripten-core:mainfrom
dschuff wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
After llvm/llvm-project#191068 it is no longer necessary (or correct).
sbc100
approved these changes
Apr 9, 2026
Member
Author
|
@sbc100 This is going to have to be synchronized because it depends on llvm/llvm-project#191329 to pass. What's our usual procedure here, just disable the test until the rollers call catch up? |
Member
Author
|
(what's the current way to disable a test completely?) |
dschuff
changed the title
aheejin
approved these changes
Apr 10, 2026
Member
aheejin
left a comment
aheejin
left a comment
There was a problem hiding this comment.
I think you can wait for llvm/llvm-project#191068 to land in the roller and land this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After llvm/llvm-project#191068 it is no longer
necessary (or correct).