Skip to content

Add ability to install prebuilt ninja #1105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sbc100 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add ability to install prebuilt ninja #1105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions emsdk_manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,6 +623,16 @@
"activated_cfg": "MINGW_ROOT='%installation_dir%'",
"activated_path": "%installation_dir%/bin"
},
{
"id": "ninja",
"version": "1.11.1",
"bitness": 64,
"windows_url": "ninja-1.11.1-win.zip",

@juj juj Jun 2, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The artifact would be good to be named x64 here. (I presume the Windows artifact is x64 and not arm64). Does this work with arm64? Can we bundle a separate windows arm64 version?

"linux_url": "ninja-1.11.1-linux.zip",
"macos_url": "ninja-1.11.1-mac.zip",

@juj juj Jun 2, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise here for Linux x64 vs arm64, and mac x64 vs arm64?

"activated_cfg": "NINJA_ROOT='%installation_dir%'",
"activated_path": "%installation_dir%"
},
{
"id": "ninja",
"version": "git-release",
Expand Down