Fix ConnectionPool deadlock from reentrant _optional_thread_lock - #1109
Open
aoright wants to merge 1 commit into
Open
Fix ConnectionPool deadlock from reentrant _optional_thread_lock#1109aoright wants to merge 1 commit into
aoright wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1089.\n\nThe sync
_init_socks5_connectionwas missing thetimeoutparameter and did not pass it down to stream.read/write, which caused infinite hangs during SOCKS5 proxy initialization.\n\nThis PR passestimeoutfrom thekwargsparameter to_init_socks5_connectionand ensures it is used when reading and writing to the SOCKS5 stream.