cli: register entire-ci as an official plugin#1791
Open
dvydra wants to merge 1 commit into
Open
Conversation
entire-ci ships as a standalone plugin (entireio/entire-ci), discovered as `entire ci …` on PATH. Add it to officialPlugins so its invocations are counted in telemetry (this list gates telemetry only — discovery/exec already work). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Registers entire-ci (invoked as entire ci … via external-command resolution) as an official plugin name for telemetry allowlisting, without changing plugin discovery/execution behavior.
Changes:
- Add
"ci"to theofficialPluginsallowlist so successfulentire ciplugin runs can be tracked when telemetry is enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://entire.io/gh/entireio/cli/trails/888
Why
entire-cinow ships as a standalone plugin (entireio/entire-ci), discovered asentire ci …on PATH — replacing the build-taggedcicommand group that was proposed in the now-closed #1753–#1758.What
Add
"ci"toofficialPlugins. This list gates telemetry only — plugin discovery and execution already work without it; it just letsentire ciinvocations be counted (third-party plugin names stay silent by design).Tests
go test ./cmd/entire/cli/ -run TestIsOfficialPluginpasses (the test snapshots the allowlist, so it's unaffected).Note
Low Risk
Single allowlist entry with no auth, data, or execution-path changes; only affects optional plugin invocation telemetry.
Overview
Adds
cito theofficialPluginstelemetry allowlist inplugin_official.go, soentire ci(the standalone entire-ci plugin) can be counted when user telemetry is enabled. Plugin discovery and execution are unchanged — onlymaybeTrackPluginInvocation/IsOfficialPluginbehavior for that name.Reviewed by Cursor Bugbot for commit 0a7421e. Configure here.