Skip to content

[Security] Fix HIGH vulnerability: go.lang.security.audit.dangerous-exec-command.dangerous-exec-command #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
orbisai0security wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −4
Open

[Security] Fix HIGH vulnerability: go.lang.security.audit.dangerous-exec-command.dangerous-exec-command #247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions cmd/entire/cli/explain.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1270,12 +1270,18 @@ func outputWithPager(w io.Writer, content string) {

// Use pager if content exceeds terminal height
if lineCount > height-2 {
pager := os.Getenv("PAGER")
if pager == "" {
pager = "less"
// Use a safe default pager instead of environment variable to prevent command injection
pagerCmd := "less"

// Validate and find the pager executable in PATH
pagerPath, err := exec.LookPath(pagerCmd)
if err != nil {
// Fallback to direct output if pager not found
fmt.Fprint(w, content)
return
}

cmd := exec.CommandContext(context.Background(), pager) //nolint:gosec // pager from env is expected
cmd := exec.CommandContext(context.Background(), pagerPath)
cmd.Stdin = strings.NewReader(content)
cmd.Stdout = f
cmd.Stderr = os.Stderr
Expand Down