Add ability for input and value of transaction to be null for Tempo Blockchain by JasoonS · Pull Request #107 · enviodev/hypersync-client-rust

JasoonS · 2026-03-19T11:44:40Z

Summary by CodeRabbit

Bug Fixes
- Transaction fields that were previously failing on null or missing values now default safely, preventing errors during data import.
Tests
- Added unit tests covering null, missing and normal cases for transaction parsing to prevent regressions.
Chores
- Package version updated to 0.7.1.

…lockchain

coderabbitai · 2026-03-19T11:44:57Z

📝 Walkthrough

Walkthrough

Updated hypersync-format crate from version 0.7.0 to 0.7.1 and added custom serde deserializers for Transaction fields. Modified deserialization logic for input and value fields to handle null or missing values by returning defaults instead of failing.

Changes

Cohort / File(s)	Summary
Version Management `hypersync-format/Cargo.toml`	Patch version bump from 0.7.0 to 0.7.1.
Deserialization Logic `hypersync-format/src/types/mod.rs`	Added two new serde helper functions: `deserialize_quantity_or_null` (treats null/missing as 0) and `deserialize_data_or_null` (treats null/missing as empty). Updated Transaction `input` field to use data deserializer and `value` field to use quantity deserializer with defaults.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Bump crate versions for release #99: Both PRs modify hypersync-format's Cargo.toml version by bumping the crate, indicating coordinated versioning between related packages.

Poem

🐰 A tiny hop through null-safe lands,
Where missing fields find gentle hands,
From point-zero-seven we now depart,
To point-one with deserializer's heart! 🎉

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding null-handling capability for transaction input and value fields specific to Tempo Blockchain, which is reflected in the code changes adding serde deserializers.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

✅ Generated successfully - (🔄 Check to regenerate)
Commit on current branch

🧪 Generate unit tests (beta)

✅ Unit Tests committed locally.

Create PR with unit tests
Commit unit tests in branch js/tempo-0x76-nulls

📝 Coding Plan

Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (2)

hypersync-format/src/types/mod.rs (2)

104-106: Consider adding tests for null input and value handling.

The existing test at line 362 covers effective_gas_price null handling. Similar test coverage for Transaction.input and Transaction.value would help document and validate the Tempo blockchain behavior.

Would you like me to generate a test case for Transaction deserialization with null/missing input and value fields?

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@hypersync-format/src/types/mod.rs` around lines 104 - 106, Add unit tests to
cover deserialization of Transaction when input and value are null or missing:
create tests that deserialize JSON fixtures with "input": null and with the
"input" field omitted to verify deserialize_data_or_null produces the expected
Data value, and similarly for "value" to ensure Transaction.value handles
null/missing correctly; reference the Transaction struct fields input and value
and the deserialize_data_or_null deserializer so the tests assert deserialized
fields match the Tempo semantics (e.g., empty/default Data or zero value) and
mirror the existing effective_gas_price null test pattern.

75-89: Consider reusing the existing nullable_default function.

These two new deserializers duplicate the existing generic nullable_default function (lines 205-211) which already handles the same pattern for any Default + Deserialize type.

You can simplify by reusing it directly:

♻️ Proposed refactor

-/// Deserialize a Quantity that may be null or missing, defaulting to zero.
-fn deserialize_quantity_or_null<'de, D>(deserializer: D) -> Result<Quantity, D::Error>
-where
-    D: Deserializer<'de>,
-{
-    Ok(Option::<Quantity>::deserialize(deserializer)?.unwrap_or_default())
-}
-
-/// Deserialize Data that may be null or missing, defaulting to empty.
-fn deserialize_data_or_null<'de, D>(deserializer: D) -> Result<Data, D::Error>
-where
-    D: Deserializer<'de>,
-{
-    Ok(Option::<Data>::deserialize(deserializer)?.unwrap_or_default())
-}

Then update the Transaction fields to use nullable_default:

-    #[serde(default, deserialize_with = "deserialize_data_or_null")]
+    #[serde(default, deserialize_with = "nullable_default")]
     pub input: Data,
     ...
-    #[serde(default, deserialize_with = "deserialize_quantity_or_null")]
+    #[serde(default, deserialize_with = "nullable_default")]
     pub value: Quantity,

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@hypersync-format/src/types/mod.rs` around lines 75 - 89, The two functions
deserialize_quantity_or_null and deserialize_data_or_null duplicate the generic
nullable_default helper; remove those two functions and update the Transaction
struct fields that reference them to use serde's deserialize_with =
"nullable_default" (or the correct path to nullable_default) so types
implementing Default + Deserialize (like Quantity and Data) reuse the existing
generic deserializer.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@hypersync-format/src/types/mod.rs`:
- Around line 110-112: The comment above the `value` field is a copy-paste error
referencing "input"; update that comment to correctly describe the `value` field
(e.g., that in the Tempo blockchain transactions may omit a value for type 0x76)
so it matches the `pub value: Quantity` declaration and its serde attribute
`deserialize_quantity_or_null`; locate the comment near `pub value: Quantity`
and replace "input" with "value" (or rewrite the sentence to accurately describe
`value`) and keep the existing serde annotation `deserialize_quantity_or_null`
unchanged.

---

Nitpick comments:
In `@hypersync-format/src/types/mod.rs`:
- Around line 104-106: Add unit tests to cover deserialization of Transaction
when input and value are null or missing: create tests that deserialize JSON
fixtures with "input": null and with the "input" field omitted to verify
deserialize_data_or_null produces the expected Data value, and similarly for
"value" to ensure Transaction.value handles null/missing correctly; reference
the Transaction struct fields input and value and the deserialize_data_or_null
deserializer so the tests assert deserialized fields match the Tempo semantics
(e.g., empty/default Data or zero value) and mirror the existing
effective_gas_price null test pattern.
- Around line 75-89: The two functions deserialize_quantity_or_null and
deserialize_data_or_null duplicate the generic nullable_default helper; remove
those two functions and update the Transaction struct fields that reference them
to use serde's deserialize_with = "nullable_default" (or the correct path to
nullable_default) so types implementing Default + Deserialize (like Quantity and
Data) reuse the existing generic deserializer.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2a7d0bc6-16b3-45e9-9d48-ce288a43b7cb

📥 Commits

Reviewing files that changed from the base of the PR and between 0372bc6 and 4057d91.

📒 Files selected for processing (2)

hypersync-format/Cargo.toml
hypersync-format/src/types/mod.rs

coderabbitai · 2026-03-19T11:47:23Z

+    // In the Tempo blockchain, transactions don't need to have an input, and don't if they are of type 0x76
+    #[serde(default, deserialize_with = "deserialize_quantity_or_null")]
    pub value: Quantity,


⚠️ Potential issue | 🟡 Minor

Fix copy-paste error in comment.

The comment on line 110 mentions "transactions don't need to have an input" but this is for the value field, not input.

📝 Proposed fix

- // In the Tempo blockchain, transactions don't need to have an input, and don't if they are of type 0x76 + // In the Tempo blockchain, transactions don't need to have a value, and don't if they are of type 0x76 #[serde(default, deserialize_with = "deserialize_quantity_or_null")] pub value: Quantity,

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

// In the Tempo blockchain, transactions don't need to have an input, and don't if they are of type 0x76

#[serde(default, deserialize_with = "deserialize_quantity_or_null")]

pub value: Quantity,

// In the Tempo blockchain, transactions don't need to have a value, and don't if they are of type 0x76

#[serde(default, deserialize_with = "deserialize_quantity_or_null")]

pub value: Quantity,

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed. In `@hypersync-format/src/types/mod.rs` around lines 110 - 112, The comment above the `value` field is a copy-paste error referencing "input"; update that comment to correctly describe the `value` field (e.g., that in the Tempo blockchain transactions may omit a value for type 0x76) so it matches the `pub value: Quantity` declaration and its serde attribute `deserialize_quantity_or_null`; locate the comment near `pub value: Quantity` and replace "input" with "value" (or rewrite the sentence to accurately describe `value`) and keep the existing serde annotation `deserialize_quantity_or_null` unchanged.

coderabbitai · 2026-03-19T12:10:15Z

Note

Unit test generation is a public access feature. Expect some limitations and changes as we gather feedback and continue to improve it.

Generating unit tests... This may take up to 20 minutes.

coderabbitai · 2026-03-19T12:10:17Z

Warning

Docstrings generation - IN PROGRESS

Generating docstrings for this pull request

coderabbitai · 2026-03-19T12:10:20Z

Note

Unit test generation is a public access feature. Expect some limitations and changes as we gather feedback and continue to improve it.

Generating unit tests... This may take up to 20 minutes.

coderabbitai · 2026-03-19T12:10:28Z

Note

Unit test generation is a public access feature. Expect some limitations and changes as we gather feedback and continue to improve it.

Generating unit tests... This may take up to 20 minutes.

@JasoonS

Docstrings generation was requested by @JasoonS. * #107 (comment) The following files were modified: * `hypersync-format/src/types/mod.rs`

coderabbitai · 2026-03-19T12:10:55Z

Note

Unit test generation is a public access feature. Expect some limitations and changes as we gather feedback and continue to improve it.

Generating unit tests... This may take up to 20 minutes.

JonoPrest · 2026-03-19T12:11:14Z

 [package]
 name = "hypersync-format"
-version = "0.7.0"
+version = "0.7.1"


Client depends on this, I think we should bump the version there as well as part of this PR. Even if you don't release it.

JonoPrest · 2026-03-19T12:13:15Z

+where
+    D: Deserializer<'de>,
+{
+    Ok(Option::<Quantity>::deserialize(deserializer)?.unwrap_or_default())


Is default 0x, or 0x0? Just thinking its probably better to have empty bytes than 0 if possible. But might break other assumptions

Yeah, we could leave empty, and handle in HyperSync, maybe better

coderabbitai · 2026-03-19T12:15:13Z

✅ Created PR with unit tests: #109

coderabbitai · 2026-03-19T12:15:15Z

✅ Unit tests committed locally. Commit: f261414f5064af1f5ef0c75f9957875bdab01bbc

coderabbitai · 2026-03-19T12:15:20Z

Note

Unit test generation is a public access feature. Expect some limitations and changes as we gather feedback and continue to improve it.

Generating unit tests... This may take up to 20 minutes.

Docstrings generation was requested by @coderabbitai[bot]. * #107 (comment) The following files were modified: * `hypersync-format/src/types/mod.rs`

coderabbitai · 2026-03-19T12:16:18Z

✅ Created PR with unit tests: #111

coderabbitai · 2026-03-19T12:16:31Z

✅ Created PR with unit tests: #112

coderabbitai · 2026-03-19T12:19:07Z

✅ Created PR with unit tests: #113

JasoonS added 2 commits March 19, 2026 13:40

Add ability for input and value of transaction to be null for Tempo B…

2dd1278

…lockchain

Bump version

4057d91

coderabbitai Bot reviewed Mar 19, 2026

View reviewed changes

coderabbitai Bot added a commit that referenced this pull request Mar 19, 2026

📝 Add docstrings to js/tempo-0x76-nulls

3d26fbe

Docstrings generation was requested by @JasoonS. * #107 (comment) The following files were modified: * `hypersync-format/src/types/mod.rs`

coderabbitai Bot mentioned this pull request Mar 19, 2026

📝 Add docstrings to js/tempo-0x76-nulls #108

Closed

JonoPrest reviewed Mar 19, 2026

View reviewed changes

coderabbitai Bot mentioned this pull request Mar 19, 2026

CodeRabbit Generated Unit Tests: Add unit tests for PR changes #109

Closed

📝 CodeRabbit Chat: Add unit tests for PR changes

f261414

coderabbitai Bot added a commit that referenced this pull request Mar 19, 2026

📝 Add docstrings to js/tempo-0x76-nulls

a0971f5

Docstrings generation was requested by @coderabbitai[bot]. * #107 (comment) The following files were modified: * `hypersync-format/src/types/mod.rs`

This was referenced Mar 19, 2026

📝 Add docstrings to js/tempo-0x76-nulls #110

Open

CodeRabbit Generated Unit Tests: Add generated unit tests #111

Closed

coderabbitai Bot mentioned this pull request Mar 19, 2026

CodeRabbit Generated Unit Tests: Add generated unit tests #112

Closed

coderabbitai Bot mentioned this pull request Mar 19, 2026

CodeRabbit Generated Unit Tests: Add generated unit tests for PR changes #113

Open

Conversation

JasoonS commented Mar 19, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot commented Mar 19, 2026

Uh oh!

coderabbitai Bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Mar 19, 2026

Uh oh!

coderabbitai Bot commented Mar 19, 2026

Uh oh!

coderabbitai Bot commented Mar 19, 2026

Uh oh!

JonoPrest Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

JonoPrest Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

JasoonS Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot commented Mar 19, 2026

Uh oh!

coderabbitai Bot commented Mar 19, 2026

Uh oh!

coderabbitai Bot commented Mar 19, 2026

Uh oh!

coderabbitai Bot commented Mar 19, 2026

Uh oh!

coderabbitai Bot commented Mar 19, 2026

Uh oh!

coderabbitai Bot commented Mar 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

JasoonS commented Mar 19, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Mar 19, 2026 •

edited

Loading

coderabbitai Bot commented Mar 19, 2026 •

edited

Loading