Conversation
Signed-off-by: Gregory Giecold <ggiecold@nvidia.com>
Signed-off-by: Gregory Giecold <ggiecold@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and impact
Mounted Redis secrets currently need a shell wrapper to copy credentials into environment variables. This draft lets the Redis client read the credential file at startup, which supports a direct distroless entrypoint without placing the credential value in an environment variable.
Scope
REDIS_AUTH_FILEandREDIS_PERSECOND_AUTH_FILEfor password orusername:passwordauthentication to Redis master/replica nodes.Verification
go test -race ./src/redis ./src/settings ./test/redisandgo test ./...passed.go test -tags=integration -run '^$' ./test/integrationcompiled the added TLS and cluster cases. The external Redis/stunnel/cluster integration environment was not run locally.Limits and review state
The file is read when the Redis client is constructed; rotation requires a process restart. This does not add IAM authentication or per-dial refresh. #1224 covers those broader features and can be compared or consolidated with this smaller change.
This remains Draft. The feature diff was also replayed and tested against upstream main
0482748; its stable patch ID is identical. The published fork branch is still based on8fe6ea4because the current-main rebase includes workflow changes that the fork's OAuth token cannot publish. No image was built or deployed.