Conversation
Record explicit Redis client calls, outcomes, attempted actions, active calls, and duration with fixed metric scopes. Map the actual server-rooted Redis scope to Prometheus counters, gauges, and a seconds histogram, and test the constructor-to-exporter path. Signed-off-by: Gregory Giecold <ggiecold@nvidia.com>
Signed-off-by: Gregory Giecold <ggiecold@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Connection counts cannot show how much work the Redis client is doing or whether its calls are slow, failing, or still pending.
Change
Add fixed-label counters, an in-flight gauge, and a latency histogram for commands, pipeline groups, and startup checks. Classify returned errors without exposing keys, arguments, or error text.
Things to note
These measure synchronous client calls and attempted actions, not server command counts or background work. The histogram exports seconds. Redis and Prometheus race tests pass, including the real server metrics scope, typed errors, cancellation, blocked reporting, and both exporter unit settings. Focused vet and formatting checks pass.