Conversation
✅ Deploy Preview for nifty-bassi-e26446 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
… fallback Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix inventory sync to avoid 404 errors on new releases
envoy.base.utils: Fetch inventories from GCS docs archive with legacy fallback
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since envoyproxy/envoy#47932, release docs are synced to GCS (
gs://<bucket>/envoy/docs/v{version}/) instead ofenvoyproxy/archive. Inventory sync was still fetching from the archive repo, so every new release 404'd and leftdocs/versions.yamlanddocs/inventories/stale.Important
envoy-docs-archiveis a placeholder bucket name. Before merge, check it against theGCS_DOCS_ARCHIVE_BUCKETrepo variable in envoyproxy/envoy. It lives in a single constant,INVENTORY_BASE_URL_DEFAULT.Changes (
abstract/project/inventory.py)inventory_urlnow builds{base_url}/envoy/docs/v{version}/objects.inv.base_urlcomes from the newinventory_base_urlproperty:$ENVOY_DOCS_ARCHIVE_URLif set, otherwiseINVENTORY_BASE_URL_DEFAULT. A trailing/is stripped.legacy_inventory_urlkeeps the oldenvoyproxy/archiveURL so older versions still resolve.fetch: tries the primary URL, then the legacy one only on a 404, and returnsNoneonly if both 404. Any other status returnsresponse.read(), as before.versions.yamlhandling and the sync/write logic.IInventoriesis also unchanged, since URL helpers aren't declared on the interface.Tests
fetch: covers primary non-404 (legacy never called), primary 404 with legacy non-404, and both 404.Release
VERSIONisn't bumped here: it's already0.6.11-dev, which the publish bot set after 0.6.10, and the release strips-dev.mainand every release branch that publishes) need to bumpenvoy.base.utilsto pick this up.