Iss9 mono move#24
Open
mdwyman wants to merge 2 commits into
Open
Conversation
…to previous value doesn't result in system being stuck in Moving
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In issue #9, the mono would get stuck in "Moving" state when attempting to set energy to current energy in auto mode (can easily happen when running experiments from Bluesky). The AO control PVs (Energy, Bragg, Lambda) will not cause any monitors to process but each PV will (via forward link) cause the mono's busy signal to be set to busy (aka "Moving"). The sequence program is responsible for "un-setting" the busy (aka Done) but since none of the AO control PVs cause a monitor to process, the sequence program doesn't leave it's waitForCMND state.
Two solutions were found:
The first solution doesn't require any changes in the underlying EPICS or sequence program support, so it can be used for older version of the optics module.
The second solution does requires the changes made in this branch.