Skip to content

Honor collector_database_exclusions in default trace and trace analysis collectors (#887 follow-up) #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikdarlingdata merged 1 commit into from
May 5, 2026
Merged

Honor collector_database_exclusions in default trace and trace analysis collectors (#887 follow-up) #934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions install/29_collect_default_trace.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,6 +369,15 @@ BEGIN
AND ft.StartTime >= @cutoff_time
AND ISNULL(ft.DatabaseID, 0) NOT IN (DB_ID(N'PerformanceMonitor'), 1, 3, 4)
AND ISNULL(ft.DatabaseID, 0) < 32761 /*exclude contained AG system databases*/
AND NOT EXISTS
(
SELECT
1/0
FROM config.collector_database_exclusions AS e
JOIN sys.databases AS d
ON d.name = e.database_name
WHERE d.database_id = ISNULL(ft.DatabaseID, 0)
)
/*
Filter for useful system events, excluding login failures
*/
Expand Down
7 changes: 7 additions & 0 deletions install/31_collect_trace_analysis.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,13 @@ BEGIN
AND trc.DatabaseName NOT IN (N'master', N'msdb', N'model', N'tempdb', N'PerformanceMonitor')
AND trc.DatabaseName NOT LIKE N'%[_]master' /*exclude contained AG system databases*/
AND trc.DatabaseName NOT LIKE N'%[_]msdb' /*exclude contained AG system databases*/
AND NOT EXISTS
(
SELECT
1/0
FROM config.collector_database_exclusions AS e
WHERE e.database_name = trc.DatabaseName
)
ORDER BY
trc.StartTime DESC;

Expand Down
Loading