Delete retired InstallerGui project directory#949
Merged
erikdarlingdata merged 1 commit intodevfrom May 8, 2026
Merged
Conversation
The standalone InstallerGui was retired in #755 — its functionality folded into the Dashboard's Add Server dialog and the new Installer.Core shared library. The .sln no longer references it, but the source directory was left on disk. Cleaning that up: removes the dead source, eliminates a stray CS8604 warning that was only surfaced when building the project directly, and keeps the repo lean. CHANGELOG already documented the retirement; no docs changes needed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the leftover
InstallerGui/directory. The standalone GUI installer was retired in #755 — its functionality is in the Dashboard's Add Server dialog and theInstaller.Coreshared library — and the.slnno longer references it, but the source files were never deleted from disk.Why now
While auditing build warnings (#945), an explicit
dotnet buildofInstallerGui/InstallerGui.csprojsurfaced a CS8604 warning. That warning isn't visible from the normal solution build (the project isn't in the .sln), but the source still exists on disk where it can mislead future audits, accumulate further warnings, and tempt drive-by edits to dead code.Changes
git rm -rf InstallerGui/(9 files, 1772 lines)Notes
CHANGELOG already documents the retirement under #755 (lines 198–249). No CHANGELOG amendment needed — this is purely the cleanup pass that #755 didn't get to.
🤖 Generated with Claude Code