Add nullability guards to comparison overlay tasks#950
Merged
erikdarlingdata merged 1 commit intodevfrom May 9, 2026
Merged
Conversation
The Blocking, Memory, and IO branches in the comparison overlay section of CorrelatedTimelineLanesControl were missing the `&& Result != null` guard the CPU and Wait branches already had. Apply uniformly so a null result from `_dataService.Get*TrendAsync` can't NRE on the subsequent .Select / .GroupBy. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three
.Result.Select/.GroupBycalls inCorrelatedTimelineLanesControl.xaml.cs(Blocking line 187, Memory line 194, IO line 199) were missing the&& Result != nullguard the CPU and Wait branches at lines 177/181 already had.Without the guard, a null result from
_dataService.Get*TrendAsyncwould NRE on the subsequent.Select/.GroupBy. CS8604 only fired on two of the five because of how generic types differ; these three were latent.Pick one nullability contract (the existing CPU/Wait pattern) and apply uniformly.
Test plan
🤖 Generated with Claude Code