fix(gate issues add): derive the severity hint from the domain list - #464
Merged
Merged
Conversation
The hint was hand-written as <low|med|high> and silently omitted `critical`, which ISSUE_SEVERITIES has accepted all along. Deriving it from the domain list makes that class of drift impossible: adding a severity now updates the hint by construction. Also fixes the same omission in the `issues add` usage line. No behaviour change beyond the message — alias handling (medium/mid/hi/crit/…) already lives in parseIssueSeverity in the domain and is untouched. typecheck clean / build OK / tests 1122 pass 0 fail (interface layer).
nao-amj
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gate issues addhand-wrote its severity hint as<low|med|high>, silently omittingcritical— a valueISSUE_SEVERITIEShas accepted all along. This derives the hint from the domain list instead, so adding a severity updates the hint by construction.ISSUE_SEVERITIES.join('|')is passed as therequireOptionplaceholdergate issuesusage block is fixed alongside itparseIssueSeverityin the domain and is untouchedTests
origin/mainand this branch were each measured from a clean worktree +npm install, so that build artefacts could not leak across the comparison.This PR adds no tests, so the totals match. The count of pre-existing failures is unchanged.
🤖 Generated with Claude Code
https://claude.ai/code/session_01VvZueYYe3yXAkpBhbcKYqe