Avoid redrawing everything on every page change#63
Open
kqr wants to merge 1 commit intoeschulte:masterfrom
Open
Avoid redrawing everything on every page change#63kqr wants to merge 1 commit intoeschulte:masterfrom
kqr wants to merge 1 commit intoeschulte:masterfrom
Conversation
By running (redraw-display), we cause a noticeable flicker in /all/ open Emacs
frames, which, while not catastrophic, is a bit of a rough edge.
If we instead redraw only the currently selected frame, we still cause a brief
flash in the presenting frame, but not in any other frames.
My current workaround for this is to add advice around redraw-display and simply
run redraw-frame instead if the major mode is epresent-mode, like-a-so:
(define-advice redraw-display
(:around (actual-redraw &rest args) epresent-only-redisplay-frame)
(if (eq major-mode 'epresent-mode)
(apply 'redraw-frame (cons nil args))
(apply actual-redraw args)))
Author
|
It is worth noting that I have tried briefly running this completely without the If we want to experiment, we could set up a defcustom variable for toggling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By running (redraw-display), we cause a noticeable flicker in /all/ open Emacs
frames, which, while not catastrophic, is a bit of a rough edge.
If we instead redraw only the currently selected frame, we still cause a brief
flash in the presenting frame, but not in any other frames.
My current workaround for this is to add advice around redraw-display and simply
run redraw-frame instead if the major mode is epresent-mode, like-a-so: