fix(compact): file switch state - #513
Open
caenrique wants to merge 2 commits into
Open
Conversation
Author
|
This is related to other fold issue I also addressed here #512 |
caenrique
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When switching files, the new buffers can briefly use folds from the previous file. Opening an empty diff also disables compact mode for the rest of the session.
Solution
Suspend compact folds while buffers are being replaced or while the current view has no changes. Reapply them after the next diff is rendered while preserving the compact-mode state.
Testing
Added regressions for buffer swaps and returning from an empty single-file view. The compact test suite passes with 32 tests.