fix(explorer): ignore stale same-path selections - #515
Open
caenrique wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Explorer callbacks only checked the selected file path before updating the diff. A file can have staged and unstaged entries with the same path, so an older callback could overwrite a newer selection and show the wrong comparison.
Solution
Track a generation for each explorer selection and reject asynchronous work when a newer selection has superseded it, including when the path is unchanged.
Testing
Added a regression test with staged and unstaged changes for the same file. It completes the two revision callbacks in reverse order and verifies that only the newer staged selection updates the view. The test fails on the parent commit with two updates and passes with the fix with one update.
Also ran the existing explorer and stale-buffer test suites.