-
Notifications
You must be signed in to change notification settings - Fork 7.8k
revert: nesso_n1: move expander and battery to external library #12107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hello facchinm, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
|
@me-no-dev sorry to bother you, just need to know if 3.3.5 is supposed to be released before the end of this week (we have to push the documentation changes and winter vacation time is not ideal 🙃 ) |
|
we will release Friday the latest. Holding because of a serious bug in one of the external components. We will disable it if it's not fixed by then |
We noticed that adding the expander code in the core has been a bad idea 🙃
Moving it out to https://github.com/arduino-libraries/Arduino_Nesso_N1 , while leaving here only an explicit error message (much more informative than just failing at link time).
@ubidefeo
@me-no-dev