Fix config manager dedup/update/delete using task name instead of unique task ID#8
Merged
etcoder-642 merged 3 commits intoJul 2, 2026
Conversation
Owner
|
Oh, thanks. This is a great catch and awesome fix. Your current fix is working and is passing the tests. But the place for |
Contributor
Author
|
ok done. Also cool project, thanks for making it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
log_task,update_task, anddelete_taskall matched tasks bytask_namein the JSON config. but task names can be duplicated (types.h:68), the unique identifier should beworking_directory(task.id), other wise I run into an issue where this causedlog_taskto incorrectly reject a task when another task with the same name (but different working directory) already existed.update_taskto silently update the wrong task when names collided.delete_taskto delete the wrong task when names collided.Fix
All three methods now use
working_directory/task.idfor matching instead oftask_name/task.name, consistent with howcreate_taskalready performs dedup checks