Fix issues when installing ete4 on Windows. #783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, it is a great progress, any managers could handle this ? |
|
@jordibc @ArnaudBelcour @idoerg @fransua Can you hearing me ? There enhancement is very important. |
|
I also give PR for this issue, the solution is equal and modify some annotations and configuration. see #793 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I am using GitHub Actions to test tools on Windows. Since I have modified these tools to use ete4, there is an issue with the Windows build when it tries to install ete4 using pip (error encountered with ete4 4.1.1 and 4.3.0). It happens during the compilation by Cython of ete4. But it is not happening with Ubuntu or macOS builds.
You can find a full traceback of this error here.
After several tests, I found that the error comes from the separator used in the
setup.pyfile:https://github.com/etetoolkit/ete/blob/ete4/setup.py#L10
Indeed, the
/works for Ubuntu and macOS, but for Windows it is not correct and leads to errors. So I created this PR to fix this and useos.path.sepinstead to specify the path separator and to have the correct one for Windows.Also, I implement the fix proposed in #763, to solve KeyError issue on Windows.
With these two changes, ete4 was installed correctly on Windows, on different runs:
https://github.com/AuReMe/metage2metabo/actions/runs/15068672311
https://github.com/AuReMe/emapper2gbk/actions/runs/15069612333
Best regards,
Arnaud Belcour.