build: fix bee hosts for PR preview#253
Merged
vojtechsimetka merged 2 commits intomasterfrom May 10, 2022
Merged
Conversation
Collaborator
🐝 PR preview in SwarmPreview URL: https://bah5acgzat64kznzgrjz5cnkuaeknpnr3sd7tx65pz4yujtly37fibmgupewa.bzz.link |
Cafe137
approved these changes
Apr 22, 2022
vojtechsimetka
suggested changes
Apr 23, 2022
|
|
||
| env: | ||
| REACT_APP_BEE_HOSTS: 'https://bee-0.gateway.ethswarm.org/,https://bee-1.gateway.ethswarm.org/,https://bee-2.gateway.ethswarm.org/,https://bee-3.gateway.ethswarm.org/,https://bee-4.gateway.ethswarm.org/,https://bee-5.gateway.ethswarm.org/,https://bee-6.gateway.ethswarm.org/,https://bee-7.gateway.ethswarm.org/,https://bee-8.gateway.ethswarm.org/,https://bee-9.gateway.ethswarm.org/' | ||
| REACT_APP_BEE_HOSTS: 'https://api.gateway.ethswarm.org/' |
Contributor
There was a problem hiding this comment.
These should still be exposed, not sure why it does not work but will check with devops. Using the api.gateway.ethswarm means we lose the frontend optimization. See #218
vojtechsimetka
approved these changes
May 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
REACT_APP_BEE_HOSTSenvironment variable was set to use the old way of addressing gateway modes that is used for the PR previews. This PR fixes it to use the correct url.