Skip to content

Fix __owner_group for non-setgid setups #2571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
f-barth wants to merge 2 commits into from
Closed

Fix __owner_group for non-setgid setups #2571

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e013653
Fix __owner_group regression for non-setgid setups
f-barth Apr 25, 2026
ea8ab24
Capture ls -ld output once for owner and group
f-barth Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions ethd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6060,9 +6060,15 @@ fi
cd "$(dirname "$(realpath "${BASH_SOURCE[0]}")")"
# Use this to make sure root doesn't end up owning files
# shellcheck disable=SC2012
__owner=$(ls -ld . | awk '{print $3}')
# shellcheck disable=SC2012
__owner_group=$(ls -ld . | awk '{print $4}')
__dir_listing=$(ls -ld .)
__owner=$(awk '{print $3}' <<< "${__dir_listing}")
if [[ -g . ]]; then
# setgid: new files inherit directory group
__owner_group=$(awk '{print $4}' <<< "${__dir_listing}")
else
# no setgid: new files inherit owner's primary group
__owner_group=$(id -gn "${__owner}")
fi

if [[ "${__owner}" = "root" ]]; then
echo "Please install ${__project_name} as a non-root user."
Expand Down