Adding a check to verify 256 epoch when consolidating/exiting/withdrawing#160
Open
valefar-on-discord wants to merge 3 commits intomainfrom
Open
Adding a check to verify 256 epoch when consolidating/exiting/withdrawing#160valefar-on-discord wants to merge 3 commits intomainfrom
valefar-on-discord wants to merge 3 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#152 was reported showing a missed check when consolidating, exiting, and withdrawing where the validator must have been active for at least 256 epochs or these transactions will fail.
We have knowledge of the validators activation_epoch but we don't of the chains current epoch. I added a PR in deposit-backend to add an API that will return the current chain head slot & epoch that can be used to make this calculation trivial.
This change is dependent on that PR being landed and the ethstaker hoodi instance updated accordingly.