Skip to content

resolve trailing slash issue with cloudrun #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mayinghan merged 1 commit into from
Aug 5, 2025
Merged

resolve trailing slash issue with cloudrun #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions eval_protocol/mcp/mcpgym.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
from mcp.server.fastmcp import Context, FastMCP
from starlette.requests import Request
from starlette.responses import JSONResponse
from uvicorn.middleware.proxy_headers import ProxyHeadersMiddleware

from .adapter import EnvironmentAdapter

Expand Down Expand Up @@ -562,11 +563,18 @@ def run(self, transport: str = "streamable-http", **kwargs):
async def run_with_high_concurrency():
starlette_app = self.mcp.streamable_http_app()

if not kwargs.get("redirect_slashes", True) and hasattr(starlette_app, "router"):
starlette_app.router.redirect_slashes = False

starlette_app.add_middleware(ProxyHeadersMiddleware, trusted_hosts="*")

config = uvicorn.Config(
starlette_app,
host=self.mcp.settings.host,
port=self.mcp.settings.port,
log_level=self.mcp.settings.log_level.lower(),
proxy_headers=True,
forwarded_allow_ips="*",
# HIGH CONCURRENCY SETTINGS
limit_concurrency=200, # Increase for HTTP endpoints + MCP
limit_max_requests=100000, # Higher request limit
Expand Down
6 changes: 3 additions & 3 deletions eval_protocol/mcp_env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,17 +104,17 @@ def make(
if evaluation_rows:
for i, row in enumerate(evaluation_rows):
dataset_info = row.input_metadata.dataset_info if row.input_metadata else {}

system_message = row.get_system_message()
system_prompt = system_message.content or ""

dataset_entry = {
"id": row.input_metadata.row_id if row.input_metadata and row.input_metadata.row_id else f"task_{i}",
"system_prompt": system_prompt,
"user_prompt_template": dataset_info.get("user_prompt_template", ""),
"environment_context": dataset_info.get("environment_context", {}),
"user_simulation": dataset_info.get("user_simulation", {}),
"evaluation_criteria": dataset_info.get("evaluation_criteria", {})
"evaluation_criteria": dataset_info.get("evaluation_criteria", {}),
}
internal_dataset.append(dataset_entry)
elif dataset:
Expand Down
Loading