Use LLM finish reason as the termination reason#56
Merged
Conversation
mayinghan
changed the title
mayinghan
commented
Aug 11, 2025
| if recording_mode: | ||
| policy.log_conversation_state_for_playback(rollout_idx, step - 1, conversation_history) | ||
|
|
||
| if rollout_end: |
Collaborator
Author
There was a problem hiding this comment.
cc @xzrderek so basically the change is remove this if branch
mayinghan
commented
Aug 11, 2025
| trajectory.usage["total_tokens"] += usage_stats.total_tokens | ||
|
|
||
| # update control plane summary if the env marks end | ||
| if env_end: |
Collaborator
Author
There was a problem hiding this comment.
@xzrderek but we still save the information in the control plane summary
mayinghan
changed the title
mayinghan
force-pushed
the
agent-loop-stop-by-policy
branch
from
8c2a7f7 to
70dd006
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use LLM finish reason as the termination reason