Skip to content

Fix full charge catalog search and prescription stock recovery - #339

Merged
evangauer merged 3 commits into
mainfrom
codex/jayne-followup-workflows
Sep 22, 2026
Merged

evangauer merged 3 commits into
mainfrom
codex/jayne-followup-workflows

Conversation

@evangauer

@evangauer evangauer commented Sep 22, 2026 •

Copy link
Copy Markdown
Owner

Charge capture searched only the first 100 products, leaving large catalogs inaccessible after the alphabetic cutoff. Inventory-linked prescriptions could silently disable Save above recorded stock, and the inventory recovery controls accepted only whole units.

The patch adds server-backed product search with paged browsing, retained selection, and loading/error/retry controls. Prescription forms explain stock constraints, fetch the current balance, and provide an inventory-review/refresh path that preserves the draft. Opening stock and adjustments now support three decimals while retaining role, tenant, nonnegative-stock, and concurrent-update protections. Recorded stock must still be reviewed in the product's actual dispensing units; no customer balances were changed.

Validation:

  • CI: 4,443 tests passed, 22 existing skips; type checks, optimized build, dependency audit, migration integrity, and RLS tenant isolation passed.
  • Browser regression: all ten original clinic-workflow checks passed. Eight follow-up checks passed across desktop Chromium and iPhone WebKit, including catalog entry 826, fractional stock recovery, untracked opening balances, stale search responses, failure/retry, and keyboard selection.
  • Authenticated deployed acceptance: six workflows passed on staging and six on the live production domain in isolated synthetic practices. Database reads independently confirmed prescriptions at 1.5 and 0.125, exact remaining stock, and invoice totals of 2.99 + 0.24 tax = 3.23. Test practices were retired afterward.

Released at app.openvpm.com as f1a3363, deployment dpl_7cQYKB8g14fuf41pbonWgEUWVXXD. The production schema gate passed; no new migration was required. See docs/testing/clinic-followup-workflows.md for the reusable acceptance workflow.

@vercel

vercel Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated
openvpm Ignored Ignored Preview Sep 22, 2026 2:24pm UTC
openvpm-app Ignored Ignored Preview Sep 22, 2026 2:24pm UTC
openvpm-docs Ignored Ignored Preview Sep 22, 2026 2:24pm UTC

Request Review

@evangauer
evangauer marked this pull request as ready for review September 22, 2026 14:25
@evangauer
evangauer merged commit f1a3363 into main Sep 22, 2026
10 checks passed
@evangauer
evangauer deleted the codex/jayne-followup-workflows branch September 22, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant