Repository navigation
Conversation
|
\cc @iseeberg79 |
|
Is this even an issue? If the "last" cheap slot is skipped it ends up as the very last slot in the plan, charging right before departure or before preconditioning. What does this PR do if preconditioning is active? |
Right now a short final slot right before the goal is skipped, including a short preconditioning block. The planner then falls back to charging continuously once time runs out, which finishes late and at a higher price. The skipping was introduced to guard against on/off cycles. If no further on/off follows (last slot or part of a longer section), there is nothing to guard and we shouldn't skip. |
|
Yes, thinking this direction as well. Kind of special case to charge a short slot / soc range which should not hit the guard. |
fixes #34466, refs #33936
The short slot rule (#6970, tolerance in #26814) protects the charger from short on/off cycles. Since 15m tariff slots, every plan needing less than 14m is a single trimmed slot without successor, so it was always skipped. Skipping a final slot avoids no cycle: the planner keeps proposing it until the insufficient time fallback charges at a worse price or misses the target.
🤖 Generated with Claude Code