fix(js): bump js-yaml to >=4.2.0 (GHSA-h67p-54hq-rp68)#2124
Merged
Conversation
Dependabot alert #53 (medium): js-yaml <= 4.1.1 has a quadratic-complexity DoS in YAML merge-key handling via repeated aliases. The only consumer in the JS package tree was supertap@3.0.1 (transitive via ava), which pulled js-yaml 3.14.2. Force js-yaml >=4.2.0 via a pnpm override. supertap@3.0.1 still calls the v3-only `yaml.safeDump`, removed in v4, so it is patched (via pnpm patchedDependencies) to use `yaml.dump`, which is safe by default in v4 and has the same signature for this usage. Verified supertap's TAP error-diagnostic path still emits a valid YAML block under js-yaml 4.2.0, and `pnpm install --frozen-lockfile` is consistent.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 520a13a | Commit Preview URL Branch Preview URL |
Jun 24 2026, 09:23 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security: Dependabot alert #53
GHSA-h67p-54hq-rp68 (medium) — js-yaml ≤ 4.1.1 has a quadratic-complexity DoS in YAML merge-key handling via repeated aliases. Fixed in 4.2.0.
The only vulnerable copy in
crates/bashkit-jswasjs-yaml@3.14.2, pulled transitively bysupertap@3.0.1(via theavatest runner). It is dev/test tooling and only dumps YAML (never parses untrusted input), so it isn't exploitable here — but the alert flags by version range, so this clears it with a real upgrade rather than a dismissal.Change
js-yaml: >=4.2.0— collapses the tree to a singlejs-yaml@4.2.0.supertap@3.0.1still callsyaml.safeDump, which was removed in js-yaml 4. Patched viapnpm.patchedDependenciesto useyaml.dump(safe by default in v4, identical signature for this call). Patch file:patches/supertap@3.0.1.patch.Verification
pnpm install --frozen-lockfileis consistent (the gate JS CI uses).js-yaml@3.14.2is gone; only4.2.0remains; allsupertapdependents resolve to the patched variant.--- … ...YAML block andfinish()works.Generated by Claude Code