Repository navigation
docs(rules): add experimental CI triggers template - #4
Merged
Merged
Conversation
Distilled from a real fix applied to a personal project's `.github/workflows/ci.yml`, which had `on: push: / pull_request:` with no filters — triggering on every ref push (including tags, redundant with CI already run on the `main` commit a tag points at), every PR regardless of target, and every file change regardless of content. - New `rules/ci-triggers-template.md`, explicitly marked experimental and not yet part of `rules/ci.md`'s mandatory checklist: scope `push` to `main`/`develop`/conventional branch prefixes, scope `pull_request` to PRs targeting `main`, add the `workflow_dispatch` + `concurrency` group already required by `rules/ci.md` but easy to forget, and skip `lint`/`test` via job-level `if:` (not a trigger-level `paths-ignore`) when a push/PR only touched docs — the job-level approach keeps the workflow always reporting, so a required status check never gets stuck waiting on a workflow that never ran - Assumes GitHub Flow (direct-to-main) as the default branching model per `rules/git.md` — a two-tier develop/main model is kept as an opt-in, not the default, since it defers integration feedback without a proportional benefit for most projects - CHANGELOG.md / TODO.md updated; not yet wired into `rules/ci.md` — intended to be applied manually on a couple more real projects first, then promoted to the mandatory checklist if it holds up Tests: 104/104 passing (adding an unreferenced rules/*.md file has no test surface — nothing in this repo's suite enumerates or validates the rules/ directory's contents against CLAUDE.md's @rules/ references). Signed-off-by: Eric Villard <dev@eviweb.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs(rules): add experimental CI triggers template
Distilled from a real fix applied to a personal project's
.github/workflows/ci.yml, which hadon: push: / pull_request:with no filters — triggering on every ref push (including tags,
redundant with CI already run on the
maincommit a tag points at),every PR regardless of target, and every file change regardless of
content.
rules/ci-triggers-template.md, explicitly marked experimentaland not yet part of
rules/ci.md's mandatory checklist: scopepushtomain/develop/conventional branch prefixes, scopepull_requestto PRs targetingmain, add theworkflow_dispatchconcurrencygroup already required byrules/ci.mdbut easy toforget, and skip
lint/testvia job-levelif:(not atrigger-level
paths-ignore) when a push/PR only touched docs —the job-level approach keeps the workflow always reporting, so a
required status check never gets stuck waiting on a workflow that
never ran
per
rules/git.md— a two-tier develop/main model is kept as anopt-in, not the default, since it defers integration feedback
without a proportional benefit for most projects
rules/ci.md—intended to be applied manually on a couple more real projects
first, then promoted to the mandatory checklist if it holds up
Tests: 104/104 passing (adding an unreferenced rules/*.md file has no
test surface — nothing in this repo's suite enumerates or validates
the rules/ directory's contents against CLAUDE.md's @rules/
references).