feat(manager): let CodeMirror editors be resized vertically - #2438
Open
elcreator wants to merge 1 commit into
Open
feat(manager): let CodeMirror editors be resized vertically#2438elcreator wants to merge 1 commit into
elcreator wants to merge 1 commit into
Conversation
Every element editor opens at CodeMirror's default 300px and stays there, which is short for a template and far too tall for a one-line chunk. .CodeMirror is already overflow: hidden (codemirror.css), which is the precondition CSS resize needs, so the affordance is one declaration. The editor then has to be told to measure again: CodeMirror draws the lines its last measurement said would fit, so without a refresh the space gained by dragging stays blank. A ResizeObserver on the wrapper does that for every instance the plugin creates. Editors created elsewhere get the handle from the same rule and are expected to refresh themselves. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MXdDGZnGP6vGt9zTDG5o3n
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every element editor opens at CodeMirror's default 300px and stays there, which is short for a template and far too tall for a one-line chunk.
.CodeMirror is already overflow: hidden (codemirror.css), which is the precondition CSS resize needs, so the affordance is one declaration. The editor then has to be told to measure again: CodeMirror draws the lines its last measurement said would fit, so without a refresh the space gained by dragging stays blank. A ResizeObserver on the wrapper does that for every instance the plugin creates.
Editors created elsewhere get the handle from the same rule and are expected to refresh themselves.