feat(parser): let a view engine ask for the DocumentParser pass - #2445
Merged
Conversation
Where a template's code is kept and whether the DocumentParser runs over the result were one decision: `if (!$template)` gated parseDocumentSource(), and the same fact turned the post-parse tail of outputContent() off - the [!nc!] rewrite, [^stats^], cleanUpMODXTags(), rewriteUrls() and escaped tag recovery. An engine that wanted those had to re-implement them, in the core's own order, from a plugin. They are now one property. Core::$runDocumentParser starts as !$template - a document rendered from a file is finished output, and nothing runs a second dialect over it - and OnLoadWebDocument fires while the decision is still open, so an engine whose syntax survives the pass sets it back to true instead of copying the pipeline. The whole tail follows that one flag. No column, no form control and no migration: which pass a document wants is a property of the request, not of the template. TemplateProcessor reads its row once instead of a column at a time; where the code lives and which engine was pinned were a query each, on every page. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01P9k7KBwVFZ6PSWH27ePZuJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Where a template's code is kept and whether the DocumentParser runs over the result were one decision:
if (!$template)gated parseDocumentSource(), and the same fact turned the post-parse tail of outputContent() off - the [!nc!] rewrite, [^stats^], cleanUpMODXTags(), rewriteUrls() and escaped tag recovery. An engine that wanted those had to re-implement them, in the core's own order, from a plugin.They are now one property. Core::$runDocumentParser starts as !$template - a document rendered from a file is finished output, and nothing runs a second dialect over it - and OnLoadWebDocument fires while the decision is still open, so an engine whose syntax survives the pass sets it back to true instead of copying the pipeline. The whole tail follows that one flag.
No column, no form control and no migration: which pass a document wants is a property of the request, not of the template.
TemplateProcessor reads its row once instead of a column at a time; where the code lives and which engine was pinned were a query each, on every page.