New Concept Exercise: Freelancer Rates#88
Merged
Conversation
Merged
Contributor
|
A little progress, but I don't have time to add the missing concepts. Oh well, someday |
Collaborator
Author
|
Can anyone review so this PR can be finally merged :D |
Collaborator
Author
|
Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This completes the existing draft for the Freelancer Rates concept exercise.
Summary
numbersandarithmetic-operatorsconcept documentation.config.jsonso both new concepts are registered and the learning path keepslasagnabeforefreelancer-rates.freelancer-ratesaswipbecause configlet does not allow it to be user-facing while itsbasicsprerequisite is only taught by thewipLasagna exercise.days_in_budgetrounds down to a whole number.Source and history
The exercise is ported from the current JavaScript concept exercise:
https://github.com/exercism/javascript/tree/main/exercises/concept/freelancer-rates
PR history reviewed:
marianfoo:concept-freelancer-rates.Validation
./bin/configlet lintnpx -y @abaplint/cli@2.119.27 abaplint.jsonnpx -y @abaplint/cli@2.119.27 abaplint_solutions.json./bin/configlet sync --exercise freelancer-rates --filepaths --metadata --docs --tests includefreelancer-rates: 12/12 tests passed.arc-1syntax check against ABAP release 758: passed for the final exemplar plus test class.Standards cross-check:
freelancer-rateshas the same concept exercise file layout aslasagna.numbersandarithmetic-operatorshave the same concept documentation file layout asbasics.Exercism: <Name>pattern.I also attempted a full-track
bin/testrun in a temporary copy on macOS after removing the GNU/usr/bin/time -fwrapper from that temp copy. It checked 50 exercise blocks; 36 passed. The failures were outside this PR, mostly from duplicate*.clas 2.abapfiles created only in the temporary copy and one existingcollatz-conjectureexemplar issue. The actual checkout has no* 2*files.