Skip to content

Fix function name from 'feeding-time-p' to 'feeding-time'#911

Open
Maartz wants to merge 1 commit into
exercism:mainfrom
Maartz:patch-1
Open

Fix function name from 'feeding-time-p' to 'feeding-time'#911
Maartz wants to merge 1 commit into
exercism:mainfrom
Maartz:patch-1

Conversation

@Maartz

@Maartz Maartz commented Jun 3, 2026

Copy link
Copy Markdown

Summary

As it's not a predicate, do not return T or NIL we should ditch the -p suffix.

Checklist

  • If docs where changed run ./bin/configlet generate to ensure all documents are properly generated.
  • CI is green

As it's not a predicate, do not return T or NIL we should ditch the `-p` suffix.
@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions Bot closed this Jun 3, 2026
@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

Hello 👋 Thanks for your PR.

This repo does not currently have dedicated maintainers. Our cross-track maintainers team will attempt to review and merge your PR, but it will likely take longer for your PR to be reviewed.

If you enjoy contributing to Exercism and have a track-record of doing so successfully, you might like to become an Exercism maintainer for this track.

Please feel free to ask any questions, or chat to us about anything to do with this PR or the reviewing process on the Exercism forum.

(cc @exercism/cross-track-maintainers)

@verdammelt verdammelt reopened this Jun 5, 2026
@verdammelt

Copy link
Copy Markdown
Member

I see that you opened 3 PRs to do this one change. I do like this change (good catch) but it should be a single PR. Do all the changes in this PR (I will close the others)

This was referenced Jun 5, 2026

@verdammelt verdammelt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must complete this change - all affected files, not just documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants