Skip to content

Check for compilation warnings in test files #1636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
angelikatyborska wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Draft

Check for compilation warnings in test files #1636

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions bin/test_exercises.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ do
mv .meta/example.ex lib/solution.ex
fi

# test compilation with --warnings-as-errors flag as the example and test should not raise any
# test compilation with --warnings-as-errors flag as the example should not raise any
set +e
compiler_results=$(MIX_ENV=test mix compile --force --warnings-as-errors 2>&1)
compile_exit_code="$?"
Expand All @@ -98,7 +98,9 @@ do

# perform unit tests
set +e
test_results=$(mix test --color --no-elixir-version-check --include pending 2> /dev/null)
# the earlier mix compile did not catch warnings in *_test.exs files,
# so we also run tests with `--warnings-as-errors`
test_results=$(mix test --warnings-as-errors --color --no-elixir-version-check --include pending 2>&1)
test_exit_code="$?"
set -e
else
Expand Down
Loading