Skip to content

Sync crypto-square tests#1627

Open
BNAndras wants to merge 2 commits intoexercism:mainfrom
BNAndras:sync-crypto-square
Open

Sync crypto-square tests#1627
BNAndras wants to merge 2 commits intoexercism:mainfrom
BNAndras:sync-crypto-square

Conversation

@BNAndras
Copy link
Member

Mark as tiny.

@github-actions
Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@BNAndras
Copy link
Member Author

Oops, this seems to be a partial dupe of #1320. I suppose you can ping Angelika to see if she's interested in continuing that PR.

@SleeplessByte
Copy link
Member

@BNAndras I think the only thing left on that one was the skip thing.

Can you test:

This test doesn't run on our online test runner because it will time-out with most implementations. It's up to you to test your solution locally.". I don't think this exercise is in any way computation intensive

If that is correct, then we should just merge hers.

@BNAndras
Copy link
Member Author

Will do.

@BNAndras
Copy link
Member Author

I ran Angelika's updated code three times on the existing six tests resulting in one time-out. So unskipping the seventh test as proposed likely would make timeouts occur more often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants