docs: tighten prose and clarify configuration options#387
Draft
jonchurch wants to merge 1 commit intoexpressjs:masterfrom
Draft
docs: tighten prose and clarify configuration options#387jonchurch wants to merge 1 commit intoexpressjs:masterfrom
jonchurch wants to merge 1 commit intoexpressjs:masterfrom
Conversation
- Update section titles: "Enable CORS" → "Allow All Origins" - Condense Dynamic Origin intro from 3 paragraphs to 2 sentences - Restructure Pre-Flight section with MDN link to simple requests - Explain app.use() vs route-level middleware for preflight - Shorten Dynamic Per-Request intro - Replace "reflect" jargon with explicit header behavior descriptions
4 tasks
Member
UlisesGascon
left a comment
UlisesGascon
left a comment
There was a problem hiding this comment.
Do you plan to make more changes @jonchurch?
efekrskl
reviewed
Jan 31, 2026
| @@ -129,12 +120,11 @@ app.listen(80, function () { | |||
|
|
|||
| ### Enabling CORS Pre-Flight | |||
Member
There was a problem hiding this comment.
Suggested change
| ### Enabling CORS Pre-Flight | |
| ### Enabling CORS Preflight |
Would be nice to standardize them all as preflight
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of an attempt to reduce confusion in the docs #384
This is the biggest doc change, as it rewrites most of what we already had. The goal with this was to tighten the prose and make things less passive voice.
Honestly gonna mark this a draft bc I want to come back to it later and see if anything else needs to be tightened, I didnt write this by hand just kept telling claude tweaks I wanted it to make.
app.use()vs route-level middleware for preflight