Closed
Conversation
Qard
force-pushed
the
diagnostics-channel
branch
from
56760d6 to
7bdd994
Compare
Contributor
|
Thank you so much @Qard ! Espeically if this can not be landed relatively soon, you should close this PR on this repo and instead open it on our upstream of the router: https://github.com/pillarjs/router . In the Express 5 branch, all of this code is deleted, so your changes would be lost if merged here. If your changes land in the router 1.x branch, they are automatically ported into the "legacy" Express 4.x code case, which is what your PR here is against. |
Author
|
Ah, cool. Didn't know about the backporting. I'll get this moved over. Thanks for the help! 👍 |
Author
|
New PR opened here: pillarjs/router#96, closing this now. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proof-of-concept implementation of the diagnostics_channel feature I'm working on in Node.js core. The value here is for APM products to be able to capture changes to routing state through the lifecycle of a request. This should of course not be merged until the module exists in Node.js itself. I'm just creating this now to prove the value to userland and to make sure a more complex framework can benefit from it.
I'll leave this as a draft PR until diagnostics_channel lands in Node.js core.