chore: improve regexes in examples#6689
Open
ericcornelissen wants to merge 1 commit intoexpressjs:masterfrom
Open
chore: improve regexes in examples#6689ericcornelissen wants to merge 1 commit intoexpressjs:masterfrom
ericcornelissen wants to merge 1 commit intoexpressjs:masterfrom
Conversation
Improve a regular expression that appears twice in the examples
which could lead to quadratic runtime if the input is crafted to
match /\{+/ plus some rejecting suffix.
In these examples this is unlikely since the markdown files are
probably trusted. This change is mostly focussed towards anyone
that starts from the examples and expands to cases where the
markdown files may not be trusted (i.e., user-provided templates).
Technically this changes the behavior of these examples, because
names may no longer contain a '{', but given they're just examples
this "breaking change" seems acceptable to me.
Signed-off-by: Eric Cornelissen <ericornelissen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve a regular expression that appears twice in the examples which could lead to quadratic runtime if the input is crafted to match
/\{+/plus some rejecting suffix. In these examples this is unlikely since the markdown files are probably trusted. This change is mostly focused towards anyone that starts from the examples and expands to cases where the markdown files may not be trusted (i.e., user-provided templates).Technically this changes the behavior of these examples, because names can no longer contain a
{, but given they're just examples this "breaking change" seems acceptable to me.