fix: prevent res.set('Content-Type') from setting header to 'false'#7039
Closed
apoorvdarshan wants to merge 1 commit intoexpressjs:masterfrom
Closed
fix: prevent res.set('Content-Type') from setting header to 'false'#7039apoorvdarshan wants to merge 1 commit intoexpressjs:masterfrom
apoorvdarshan wants to merge 1 commit intoexpressjs:masterfrom
Conversation
When mime.contentType() cannot resolve a shorthand value, it returns false, which was silently set as the Content-Type header. Fall back to the original value instead. Fixes expressjs#7034
Contributor
|
Duplicate of #7035 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mime.contentType()cannot resolve a shorthand value (e.g.,'custom-type'), it returnsfalse, which was silently set as the literal Content-Type header string"false"res.type()already handles this caseFixes #7034
Test plan
res.set('Content-Type', 'custom-type')preserves the original value instead of setting"false"res.set('Content-Type', 'application/x-custom')works correctly with full MIME types