feat: tablet/desktop header and sidebar navigation#2185
feat: tablet/desktop header and sidebar navigation#2185g-francesca merged 83 commits intoredesignfrom
Conversation
|
Could you please check whether the current implementation is closer to what you had in mind? Here’s how I’ve implemented the slide-in/slide-out behavior: • When navigating within docs/api/middleware pages, the lateral column is visible by default. It can be closed using the back button. |
There was a problem hiding this comment.
The back button closes the submenu.
I think implementing sidebar toggle is a useful feature for this design. Ref image
I noticed following user experience issues.
Let me know if you are having different thoughts. Thank you👍
@bjohansebas I’ve checked this, and it’s happening because the page you’re viewing contains a table, including very long text, and this is causing the horizontal overflow. The markdown file wraps the table in a I’ve made a note of this so I can come back and address it later, when reviewing the documentation pages. |
Hi @ShubhamOulkar,
Please let me know if these changes work for you, or if you had something different in mind. Sharing some screenshots:
|
|
Hi 👋 @g-francesca, I think my explanation for toggler feature do not reach you correctly. What I mean in this image is https://www.awesomescreenshot.com/image/58925298?key=c3904ce34fde4f282e83f7c3a9aa18f3 that docs, api, resources buttons should perform toggle of the sidebar. Current design is also looking great to me. But there is bug in it. Ref bug. |
ShubhamOulkar
left a comment
There was a problem hiding this comment.
I am fine with current design. Please fix bug ref in video.
Thank you @g-francesca for your kind support.
I've fixed the bug. Thanks for reporting! I missed it before. I'm closing this PR. |




Deploy Preview: https://deploy-preview-2185--expressjscom-preview.netlify.app/en/
This PR completes the desktop implementation of the redesigned navigation system for expressjs.com, building on the mobile navigation foundation.
Navigation System
Desktop/Tablet Features
Header Component
Added:
Sidebar Component
SidebarController